Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix getBestBlockHeight miss unfinalizedBlocks arg #215

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Conversation

jiqiang90
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

jiqiang90 and others added 2 commits November 23, 2023 16:26

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Scott Twiname <[email protected]>
Copy link

github-actions bot commented Nov 23, 2023

Coverage report

❌ An unexpected error occurred. For more details, check console

Error: The process '/usr/local/bin/yarn' failed with exit code 1
St.
Category Percentage Covered / Total
🔴 Statements 51.26% 3042/5935
🟡 Branches 64.78% 298/460
🔴 Functions 40.34% 96/238
🔴 Lines 51.26% 3042/5935

Test suite run failed

Failed tests: 6/56. Failed suites: 6/10.
  ● Dictionary queries › Correct dictionary query with dynamic ds › Builds a groupded query for multiple dynamic ds

    expect(received).toEqual(expected) // deep equality

    - Expected  - 8
    + Received  + 0

    @@ -10,18 +10,10 @@
          "entity": "evmLogs",
        },
        Object {
          "conditions": Array [
            Object {
    -         "field": "address",
    -         "matcher": "in",
    -         "value": Array [
    -           "address1",
    -           "address2",
    -         ],
    -       },
    -       Object {
              "field": "topics0",
              "matcher": "equalTo",
              "value": "0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef",
            },
          ],

      408 |       );
      409 |
    > 410 |       expect(queryEntry).toEqual([
          |                          ^
      411 |         {
      412 |           entity: 'evmLogs',
      413 |           conditions: [

      at Object.<anonymous> (packages/node/src/indexer/fetch.service.spec.ts:410:26)


  ● CeloJsonRpcProvider › should not set gasLimit to zero for blocks after the hard fork

    expect(received).toEqual(expected) // deep equality

    - Expected  - 1
    + Received  + 1

      Object {
    -   "hex": "0x01e84800",
    +   "hex": "0x02faf080",
        "type": "BigNumber",
      }

      31 |       await provider.send('eth_getBlockByNumber', ['latest', true]),
      32 |     );
    > 33 |     expect(BigNumber.from(block.gasLimit)).toEqual(BigNumber.from(0x01e84800));
         |                                            ^
      34 |   });
      35 | });
      36 |

      at Object.<anonymous> (packages/node/src/ethereum/ethers/celo/celo-json-rpc-batch-provider.spec.ts:33:44)


  ● CeloJsonRpcProvider › should not set gasLimit to zero for blocks after the hard fork

    expect(received).toEqual(expected) // deep equality

    - Expected  - 1
    + Received  + 1

      Object {
    -   "hex": "0x01e84800",
    +   "hex": "0x02faf080",
        "type": "BigNumber",
      }

      29 |       await provider.send('eth_getBlockByNumber', ['latest', true]),
      30 |     );
    > 31 |     expect(BigNumber.from(block.gasLimit)).toEqual(BigNumber.from(0x01e84800));
         |                                            ^
      32 |   });
      33 | });
      34 |

      at Object.<anonymous> (packages/node/src/ethereum/ethers/celo/celo-json-rpc-provider.spec.ts:31:44)


  ● CeloJsonRpcProvider › should not set gasLimit to zero for blocks after the hard fork

    expect(received).toEqual(expected) // deep equality

    - Expected  - 1
    + Received  + 1

      Object {
    -   "hex": "0x01e84800",
    +   "hex": "0x02faf080",
        "type": "BigNumber",
      }

      29 |       await provider.send('eth_getBlockByNumber', ['latest', true]),
      30 |     );
    > 31 |     expect(BigNumber.from(block.gasLimit)).toEqual(BigNumber.from(0x01e84800));
         |                                            ^
      32 |   });
      33 | });
      34 |

      at Object.<anonymous> (packages/node/src/ethereum/ethers/celo/celo-ws-provider.spec.ts:31:44)


  ● ApiService › can get the finalized height

    expect(received).toBeGreaterThan(expected)

    Expected: > 16000000
    Received:   0

      88 |
      89 |     console.log('Finalized height', height);
    > 90 |     expect(height).toBeGreaterThan(16_000_000);
         |                    ^
      91 |   });
      92 |
      93 |   it('ensure api errorCode is exposed when throwing', async () => {

      at Object.<anonymous> (packages/node/src/ethereum/api.service.ethereum.test.ts:90:20)


  ● Api.ethereum › Resolves the correct tags for finalization

    expect(received).toBeTruthy()

    Received: false

      271 |   it('Resolves the correct tags for finalization', async () => {
      272 |     // Ethereum
    > 273 |     expect((ethApi as any).supportsFinalization).toBeTruthy();
          |                                                  ^
      274 |
      275 |     // Moonbeam
      276 |     ethApi = new EthereumApi(

      at Object.<anonymous> (packages/node/src/ethereum/api.ethereum.test.ts:273:50)

Report generated by 🧪jest coverage report action from 1729904

@stwiname stwiname merged commit 67589b7 into main Nov 23, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants